Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix now frac in column option #214

Merged
merged 14 commits into from
Apr 18, 2019
Merged

fix now frac in column option #214

merged 14 commits into from
Apr 18, 2019

Conversation

Ryan-Git
Copy link
Contributor

What problem does this PR solve?

#186 is not completely fixed by #211 , this PR parses fraction of CURRENT_TIMESTAMP in ON UPDATE clause.

What is changed and how it works?

ref parsed NowSymOptionFraction in ColumnOption rather than manually construct it.

Check List

Tests

adjusted related parser_test.go

@tiancaiamao
Copy link
Collaborator

PTAL @winkyao @crazycs520

@Ryan-Git
Copy link
Contributor Author

any update?

@tiancaiamao
Copy link
Collaborator

PTAL @winkyao @crazycs520

@tiancaiamao
Copy link
Collaborator

LGTM

@Ryan-Git Ryan-Git mentioned this pull request Mar 18, 2019
Closed
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tiancaiamao
Copy link
Collaborator

Ping @winkyao @crazycs520

winkyao
winkyao approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Apr 18, 2019

Please remember to update parser version in TiDB go.mod to use this fixed.

crazycs520
crazycs520 approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao merged commit 27f4460 into pingcap:master Apr 18, 2019
@Ryan-Git Ryan-Git deleted the fix-col-op-now-frac branch April 18, 2019 11:33
wshwsh12 pushed a commit to wshwsh12/parser that referenced this pull request Jul 30, 2019
@Ryan-Git @wshwsh12
parser: fix now frac in column option (pingcap#214)
ce81cfd
tangenta pushed a commit to tangenta/parser that referenced this pull request Sep 28, 2019
@Ryan-Git @tangenta
parser: fix now frac in column option (pingcap#214)
c2ef9cb
@tangenta tangenta mentioned this pull request Sep 28, 2019
Merged
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@Ryan-Git @tiancaiamao
parser: fix now frac in column option (pingcap#214)
1602e08
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@Ryan-Git @tiancaiamao
parser: fix now frac in column option (pingcap#214)
50dda70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ryan-Git @tiancaiamao @CLAassistant @winkyao @crazycs520